Don't log AWS SDK stack trace, updates documentation #3952
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Miles <[email protected]>
|
I'm new to the project but it's not clear to me that we use the Spring AI AWS region property... There's a lot of code and I definitely could be missing it, but I don't see anyplace where we use this property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the
BedrockProxyChatModelsuch that it no longer logs a stack trace if the Amazon SDK for Java fails to find a region. Instead a warning is logged letting the developer know which region is being used.This also updates the documentation to let people know that first we use the SDK's choice of region and fall back to the Spring AI property only if that is not set.
Resolves #3951